-
Notifications
You must be signed in to change notification settings - Fork 962
Xpay bad nodes #8608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Xpay bad nodes #8608
Conversation
7f51753 to
9585fe2
Compare
9585fe2 to
9e297ce
Compare
rustyrussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor API changes, and I need to be convinced of the xpay change.
|
@rustyrussell: regarding the direction of the channels, either "in" or "out", it is true that it gives us more control but I can't think of a practical use case for making that distinction. If a node's out channels are heavily penalized that means we will eventually not going to route through it's in-channels anyways. |
|
I don't quite see a case where we'd ever set This is similar to the Boltz situation, since they keep their channels purposefully unbalanced, with most capacity on their peer's side. We temporarily fixed that by blocklisting all outgoing channels: this way we'd never end up at that node, unless it is the destination, because incoming edges are still available. And I think it can be generalized this way. I'd vote for removing the direction param, and just always using |
9e297ce to
c1370d9
Compare
We add one more field to biases: "timestamp". With the timestamp variable old biases can be removed with the askrene-age command. Changelog-Added: Plugins: askrene channel biases now have an associated timestamp, and are timed out by askrene-age Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Changelog-Added: askrene-bias-node: an RPC command to set a bias on node's outgoing or incoming channels. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
c1370d9 to
0940e7f
Compare
Several changes to askrene, mainly to introduce penalties (biases) on nodes and channels that
can be used across payments.
It addresses issue #8600.
- [ ] add expiration on biases,- [ ] add expiration on knowledge data,- [x] penalize nodes on xpay that have failing channels,